From da937efdeaa4f99e491e8e850bf0b4470966deeb Mon Sep 17 00:00:00 2001 From: Jean-Christian Denis Date: Sun, 16 Apr 2023 12:10:31 +0200 Subject: [PATCH] no need to check variable on private methods --- src/Uninstaller.php | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/Uninstaller.php b/src/Uninstaller.php index 541f695..bec35ba 100644 --- a/src/Uninstaller.php +++ b/src/Uninstaller.php @@ -262,8 +262,8 @@ class Uninstaller private function addAction(string $group, string $cleaner, string $action, string $ns): void { - // invalid group or no current module or no cleaner id or ns - if (!self::group($group) || null === $this->module || empty($cleaner) || empty($ns)) { + // no current module or no cleaner id or ns + if (null === $this->module || empty($cleaner) || empty($ns)) { return; } // unknow cleaner action @@ -283,7 +283,7 @@ class Uninstaller private function getActions(string $group, string $id): array { - if (!self::group($group) || !isset($this->actions[$group][$id])) { + if (!isset($this->actions[$group][$id])) { return []; } $res = []; @@ -296,9 +296,4 @@ class Uninstaller return $res; } - - private function group(string $group): bool - { - return in_array($group, ['user', 'direct']); - } }