From d2febcdebad9cbc9c9ab8d5a8cf12d2bdf4d1964 Mon Sep 17 00:00:00 2001
From: Jean-Christian Denis <contact@jcdenis.fr>
Date: Wed, 7 Dec 2022 23:57:05 +0100
Subject: [PATCH] no more need to set version

---
 _install.php | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/_install.php b/_install.php
index 21d80eb..1891b2c 100644
--- a/_install.php
+++ b/_install.php
@@ -14,10 +14,11 @@ if (!defined('DC_CONTEXT_ADMIN')) {
     return null;
 }
 
-$new_version = dcCore::app()->plugins->moduleInfo('activityReport', 'version');
-$old_version = dcCore::app()->getVersion('activityReport');
-
-if (version_compare($old_version, $new_version, '>=')) {
+if (version_compare(
+    dcCore::app()->getVersion('activityReport'), 
+    dcCore::app()->plugins->moduleInfo('activityReport', 'version'), 
+    '>='
+)) {
     return null;
 }
 
@@ -54,8 +55,6 @@ try {
     $si      = new dbStruct(dcCore::app()->con, dcCore::app()->prefix);
     $changes = $si->synchronize($s);
 
-    dcCore::app()->setVersion('activityReport', $new_version);
-
     return true;
 } catch (Exception $e) {
     dcCore::app()->error->add($e->getMessage());