From cd5f71d98cb26bc4f1130793cea2b245ed58c74f Mon Sep 17 00:00:00 2001
From: Jean-Christian Denis <contact@jcdenis.fr>
Date: Thu, 20 Apr 2023 21:57:05 +0200
Subject: [PATCH] cosmetic nullsafe fix

---
 src/Backend.php  | 14 ++++++++++++++
 src/Frontend.php | 14 ++++++++++++--
 src/Install.php  |  5 +++++
 src/Manage.php   | 11 +++++++++++
 4 files changed, 42 insertions(+), 2 deletions(-)

diff --git a/src/Backend.php b/src/Backend.php
index 2ac1588..fd27c36 100644
--- a/src/Backend.php
+++ b/src/Backend.php
@@ -26,6 +26,7 @@ class Backend extends dcNsProcess
     {
         static::$init = defined('DC_CONTEXT_ADMIN')
             && My::phpCompliant()
+            && !is_null(dcCore::app()->auth) && !is_null(dcCore::app()->blog) // nullsafe PHP < 8.0
             && dcCore::app()->auth->check(dcCore::app()->auth->makePermissions([
                 dcCore::app()->auth::PERMISSION_CONTENT_ADMIN,
             ]), dcCore::app()->blog->id);
@@ -39,6 +40,11 @@ class Backend extends dcNsProcess
             return false;
         }
 
+        // nullsafe PHP < 8.0
+        if (is_null(dcCore::app()->auth) || is_null(dcCore::app()->blog) || is_null(dcCore::app()->adminurl)) {
+            return false;
+        }
+
         dcCore::app()->menu[dcAdmin::MENU_PLUGINS]->addItem(
             My::name(),
             dcCore::app()->adminurl->get('admin.plugin.' . My::id()),
@@ -50,11 +56,19 @@ class Backend extends dcNsProcess
 
         dcCore::app()->addBehaviors([
             'adminPageHTMLHead' => function (): void {
+                // nullsafe PHP < 8.0
+                if (is_null(dcCore::app()->blog)) {
+                    return;
+                }
                 if (dcCore::app()->blog->settings->get(My::id())->get('flag')) {
                     echo dcPage::cssModuleLoad(My::id() . '/css/backend.css');
                 }
             },
             'adminDashboardFavoritesV2' => function (dcFavorites $favs): void {
+                // nullsafe PHP < 8.0
+                if (is_null(dcCore::app()->auth) || is_null(dcCore::app()->adminurl)) {
+                    return;
+                }
                 $favs->register(My::id(), [
                     'title'       => My::name(),
                     'url'         => dcCore::app()->adminurl->get('admin.plugin.' . My::id()),
diff --git a/src/Frontend.php b/src/Frontend.php
index dde2ba5..18cf6ed 100644
--- a/src/Frontend.php
+++ b/src/Frontend.php
@@ -36,6 +36,11 @@ class Frontend extends dcNsProcess
         }
 
         dcCore::app()->addBehavior('publicBeforeDocument', function (): void {
+            // nullsafe PHP < 8.0
+            if (is_null(dcCore::app()->blog)) {
+                return;
+            }
+
             if (!dcCore::app()->blog->settings->get(My::id())->get('flag')) {
                 return;
             }
@@ -53,12 +58,17 @@ class Frontend extends dcNsProcess
             }
             $extra_urls = json_decode(dcCore::app()->blog->settings->get(My::id())->get('extra_urls'), true);
             if (!in_array(Http::realIP(), $all_allowed_ip)) {
-                dcCore::app()->url->registerDefault(function ($args) {
+                dcCore::app()->url->registerDefault(function (?string $args): void {
                     dcCore::app()->url->type = 'default';
 
                     throw new Exception('Blog under construction', 503);
                 });
-                dcCore::app()->url->registerError(function ($args, $type, $e) {
+                dcCore::app()->url->registerError(function (?string $args, ?string $type, Exception $e): void {
+                    // nullsafe PHP < 8.0
+                    if (is_null(dcCore::app()->ctx)) {
+                        return;
+                    }
+
                     header('Content-Type: text/html; charset=UTF-8');
                     Http::head(503, 'Service Unavailable');
                     dcCore::app()->url->type = '503';
diff --git a/src/Install.php b/src/Install.php
index 9355a2b..9b2193c 100644
--- a/src/Install.php
+++ b/src/Install.php
@@ -35,6 +35,11 @@ class Install extends dcNsProcess
             return false;
         }
 
+        // nullsafe PHP < 8.0
+        if (is_null(dcCore::app()->blog)) {
+            return false;
+        }
+
         try {
             $s = dcCore::app()->blog->settings->get(My::id());
 
diff --git a/src/Manage.php b/src/Manage.php
index 6487b97..8196281 100644
--- a/src/Manage.php
+++ b/src/Manage.php
@@ -41,6 +41,7 @@ class Manage extends dcNsProcess
     {
         static::$init = defined('DC_CONTEXT_ADMIN')
             && My::phpCompliant()
+            && !is_null(dcCore::app()->auth) && !is_null(dcCore::app()->blog) // nullsafe PHP < 8.0
             && dcCore::app()->auth->check(dcCore::app()->auth->makePermissions([
                 dcAuth::PERMISSION_CONTENT_ADMIN,
             ]), dcCore::app()->blog->id);
@@ -54,6 +55,11 @@ class Manage extends dcNsProcess
             return false;
         }
 
+        // nullsafe PHP < 8.0
+        if (is_null(dcCore::app()->blog) || is_null(dcCore::app()->adminurl)) {
+            return false;
+        }
+
         $s = dcCore::app()->blog->settings->get(My::id());
 
         if (!empty($_POST['saveconfig'])) {
@@ -96,6 +102,11 @@ class Manage extends dcNsProcess
             return;
         }
 
+        // nullsafe PHP < 8.0
+        if (is_null(dcCore::app()->auth) || is_null(dcCore::app()->blog) || is_null(dcCore::app()->adminurl)) {
+            return;
+        }
+
         $s       = dcCore::app()->blog->settings->get(My::id());
         $editor  = dcCore::app()->auth->getOption('editor');
         $nb_rows = count(json_decode($s->get('allowed_ip'), true));