cosmetic code doc

CHANGELOG.md

@@ -1,3 +1,27 @@
+dcLog 1.7.3 - 2023.11.04
+===========================================================
+* Require Dotclear 2.28
+* Require PHP 8.1
+* Cosmetic code doc
+
+dcLog 1.7.2 - 2023.10.13
+===========================================================
+* Require Dotclear 2.28
+* Require PHP 8.1
+* Upgrade to last minute change to Dotclear 2.28
+
+dcLog 1.7.1 - 2023.10.11
+===========================================================
+* Require Dotclear 2.28
+* Require PHP 8.1
+* Code review
+
+dcLog 1.7 - 2023.10.07
+===========================================================
+* Require Dotclear 2.28
+* Require PHP 8.1
+* Upgrade to Dotclear 2.28
+
 dcLog 1.6 - 2023.08.14
 ===========================================================
 * Require Dotclear 2.27

README.md

@@ -1,25 +1,22 @@
 # README
 
-[![Release](https://img.shields.io/badge/release-1.6-a2cbe9.svg)](https://git.dotclear.watch/JcDenis/dcLog/releases)
-[![Date](https://img.shields.io/badge/date-2023.08.14-c44d58.svg)](https://git.dotclear.watch/JcDenis/dcLog/releases)
-[![Dotclear](https://img.shields.io/badge/dotclear-v2.27-137bbb.svg)](https://fr.dotclear.org/download)
+[![Release](https://img.shields.io/badge/release-1.7.3-a2cbe9.svg)](https://git.dotclear.watch/JcDenis/dcLog/releases)
+![Date](https://img.shields.io/badge/date-2023.11.04-c44d58.svg)
+[![Dotclear](https://img.shields.io/badge/dotclear-v2.28-137bbb.svg)](https://fr.dotclear.org/download)
 [![Dotaddict](https://img.shields.io/badge/dotaddict-official-9ac123.svg)](https://plugins.dotaddict.org/dc2/details/dcLog)
-[![License](https://img.shields.io/github/license/JcDenis/dcLog)](https://git.dotclear.watch/JcDenis/dcLog/blob/master/LICENSE)
+[![License](https://img.shields.io/badge/license-GPL--2.0-ececec.svg)](https://git.dotclear.watch/JcDenis/dcLog/src/branch/master/LICENSE)
 
-## WHAT IS DCLOG ?
+## ABOUT
 
-_dcLog_ is a plugin for the open-source 
-web publishing software called Dotclear.
+_dcLog_ is a plugin for the open-source web publishing software called [Dotclear](https://www.dotclear.org).
 
-Display dotclear's logs.
+> Display dotclear's logs.
 
 ## REQUIREMENTS
 
-_dcLog_ requires: 
-
 * PHP 8.1+
-* Dotclear 2.27
-* super admin permission
+* Dotclear 2.28
+* Dotclear super admin permission
 
 ## USAGE
 
@@ -31,13 +28,14 @@ Once it's done you can manage your logs from menu
 
 ## LINKS
 
-* License : [GNU GPL v2](https://www.gnu.org/licenses/old-licenses/lgpl-2.0.html)
-* Source & contribution : [Gitea Page](https://git.dotclear.watch/JcDenis/dcLog) or [GitHub Page](https://github.com/JcDenis/dcLog)
-* Packages & details: [Gitea Page](https://git.dotclear.watch/JcDenis/dcLog/releases) or [Dotaddict Page](https://plugins.dotaddict.org/dc2/details/dcLog)
+* [License](https://git.dotclear.watch/JcDenis/dcLog/src/branch/master/LICENSE)
+* [Packages & details](https://git.dotclear.watch/JcDenis/dcLog/releases) (or on [Dotaddict](https://plugins.dotaddict.org/dc2/details/dcLog))
+* [Sources & contributions](https://git.dotclear.watch/JcDenis/dcLog) (or on [GitHub](https://github.com/JcDenis/dcLog))
+* [Issues & security](https://git.dotclear.watch/JcDenis/dcLog/issues) (or on [GitHub](https://github.com/JcDenis/dcLog/issues))
 
 ## CONTRIBUTORS
 
 * Tomtom (author)
-* Jean-Christian Denis
+* Jean-Christian Denis (latest)
 
 You are welcome to contribute to this code.

_define.php

@@ -1,29 +1,26 @@
 <?php
 /**
- * @brief dcLog, a plugin for Dotclear 2
+ * @file
+ * @brief       The plugin dcLog definition
+ * @ingroup     dcLog
  *
- * @package Dotclear
- * @subpackage Plugin
+ * @defgroup    dcLog Plugin dcLog.
  *
- * @author Tomtom and Contributors
+ * Displays Dotclear logs.
  *
- * @copyright Jean-Christian Denis
+ * @author      Tomtom (author)
+ * @author      Jean-Christian Denis (latest)
  * @copyright   GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
  */
-if (!defined('DC_RC_PATH')) {
-    return null;
-}
+declare(strict_types=1);
 
 $this->registerModule(
     "Dotclear's logs",
     'Displays Dotclear logs',
     'Tomtom and Contributors',
-    '1.6',
+    '1.7.3',
     [
-        'requires' => [
-            ['php', '8.1'],
-            ['core', '2.27'],
-        ],
+        'requires'    => [['core', '2.28']],
         'permissions' => null,
         'type'        => 'plugin',
         'support'     => 'https://git.dotclear.watch/JcDenis/' . basename(__DIR__) . '/issues',

dcstore.xml

@@ -2,11 +2,11 @@
 <modules xmlns:da="http://dotaddict.org/da/">
   <module id="dcLog">
     <name>Dotclear's logs</name>
-    <version>1.6</version>
+    <version>1.7.3</version>
     <author>Tomtom and Contributors</author>
     <desc>Displays Dotclear logs</desc>
-    <file>https://git.dotclear.watch/JcDenis/dcLog/releases/download/v1.6/plugin-dcLog.zip</file>
-    <da:dcmin>2.27</da:dcmin>
+    <file>https://git.dotclear.watch/JcDenis/dcLog/releases/download/v1.7.3/plugin-dcLog.zip</file>
+    <da:dcmin>2.28</da:dcmin>
     <da:details>https://git.dotclear.watch/JcDenis/dcLog/src/branch/master/README.md</da:details>
     <da:support>https://git.dotclear.watch/JcDenis/dcLog/issues</da:support>
   </module>

src/Backend.php

@@ -1,25 +1,22 @@
 <?php
-/**
- * @brief dcLog, a plugin for Dotclear 2
- *
- * @package Dotclear
- * @subpackage Plugin
- *
- * @author Tomtom and Contributors
- *
- * @copyright Jean-Christian Denis
- * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
- */
+
 declare(strict_types=1);
 
 namespace Dotclear\Plugin\dcLog;
 
 use ArrayObject;
-use dcCore;
+use Dotclear\App;
 use Dotclear\Core\Process;
 use Dotclear\Core\Backend\Favorites;
-use Dotclear\Core\Backend\Menus;
 
+/**
+ * @brief       dcLog backend class.
+ * @ingroup     dcLog
+ *
+ * @author      Tomtom (author)
+ * @author      Jean-Christian Denis (latest)
+ * @copyright   GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
+ */
 class Backend extends Process
 {
     public static function init(): bool
@@ -33,9 +30,9 @@ class Backend extends Process
             return false;
         }
 
-        My::addBackendMenuItem(Menus::MENU_SYSTEM);
+        My::addBackendMenuItem(App::backend()->menus()::MENU_SYSTEM);
 
-        dcCore::app()->addBehaviors([
+        App::behavior()->addBehaviors([
             // backend user preference for logs list columns
             'adminColumnsListsV2' => function (ArrayObject $cols): void {
                 $cols[My::BACKEND_LIST_ID] = [

src/BackendList.php

@@ -1,15 +1,5 @@
 <?php
-/**
- * @brief dcLog, a plugin for Dotclear 2
- *
- * @package Dotclear
- * @subpackage Plugin
- *
- * @author Tomtom and Contributors
- *
- * @copyright Jean-Christian Denis
- * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
- */
+
 declare(strict_types=1);
 
 namespace Dotclear\Plugin\dcLog;
@@ -30,7 +20,12 @@ use Dotclear\Helper\Html\Form\{
 };
 
 /**
- * Backend logs list helper.
+ * @brief       dcLog logs list class.
+ * @ingroup     dcLog
+ *
+ * @author      Tomtom (author)
+ * @author      Jean-Christian Denis (latest)
+ * @copyright   GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
  */
 class BackendList extends Listing
 {
@@ -53,7 +48,7 @@ class BackendList extends Listing
             return;
         }
 
-        $pager = new Pager($page, $this->rs_count, $nb_per_page, 10);
+        $pager = new Pager($page, (int) $this->rs_count, $nb_per_page, 10);
 
         $cols = new ArrayObject([
             'date' => (new Text('th', __('Date')))
@@ -74,7 +69,7 @@ class BackendList extends Listing
 
         $lines = [];
         while ($this->rs->fetch()) {
-            $lines[] = $this->line(isset($_POST['entries']) && in_array($this->rs->log_id, $_POST['entries']));
+            $lines[] = $this->line(isset($_POST['entries']) && in_array($this->rs->f('log_id'), $_POST['entries']));
         }
 
         echo
@@ -115,25 +110,25 @@ class BackendList extends Listing
                 ->class('nowrap minimal')
                 ->items([
                     (new Checkbox(['entries[]'], $checked))
-                        ->value($this->rs->log_id),
+                        ->value($this->rs->f('log_id')),
                 ]),
-            'date' => (new Text('td', Html::escapeHTML(Date::dt2str(__('%Y-%m-%d %H:%M'), $this->rs->log_dt))))
+            'date' => (new Text('td', Html::escapeHTML(Date::dt2str(__('%Y-%m-%d %H:%M'), $this->rs->f('log_dt')))))
                 ->class('nowrap minimal'),
-            'msg' => (new Text('td', nl2br(Html::escapeHTML($this->rs->log_msg))))
+            'msg' => (new Text('td', nl2br(Html::escapeHTML($this->rs->f('log_msg')))))
                 ->class('maximal'),
-            'blog' => (new Text('td', Html::escapeHTML($this->rs->blog_id)))
+            'blog' => (new Text('td', Html::escapeHTML($this->rs->f('blog_id'))))
                 ->class('nowrap minimal'),
-            'table' => (new Text('td', Html::escapeHTML($this->rs->log_table)))
+            'table' => (new Text('td', Html::escapeHTML($this->rs->f('log_table'))))
                 ->class('nowrap minimal'),
             'user' => (new Text('td', Html::escapeHTML($this->rs->getUserCN())))
                 ->class('nowrap minimal'),
-            'ip' => (new Text('td', Html::escapeHTML($this->rs->log_ip)))
+            'ip' => (new Text('td', Html::escapeHTML($this->rs->f('log_ip'))))
                 ->class('nowrap minimal'),
         ]);
         $this->userColumns(My::BACKEND_LIST_ID, $cols);
 
         return
-        (new Para('p' . $this->rs->log_id, 'tr'))
+        (new Para('p' . $this->rs->f('log_id'), 'tr'))
             ->class('line')
             ->items(iterator_to_array($cols));
     }

src/Manage.php

@@ -1,20 +1,10 @@
 <?php
-/**
- * @brief dcLog, a plugin for Dotclear 2
- *
- * @package Dotclear
- * @subpackage Plugin
- *
- * @author Tomtom and Contributors
- *
- * @copyright Jean-Christian Denis
- * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
- */
+
 declare(strict_types=1);
 
 namespace Dotclear\Plugin\dcLog;
 
-use dcCore;
+use Dotclear\App;
 use Dotclear\Core\Process;
 use Dotclear\Core\Backend\{
     Notices,
@@ -31,7 +21,12 @@ use Dotclear\Helper\Html\Form\{
 use Exception;
 
 /**
- * Manage logs list
+ * @brief       dcLog manage class.
+ * @ingroup     dcLog
+ *
+ * @author      Tomtom (author)
+ * @author      Jean-Christian Denis (latest)
+ * @copyright   GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
  */
 class Manage extends Process
 {
@@ -51,7 +46,11 @@ class Manage extends Process
         // Delete logs
         if ($current->selected_logs && !empty($current->entries) || $current->all_logs) {
             try {
-                dcCore::app()->log->delLogs($current->entries, $current->all_logs);
+                if ($current->all_logs) {
+                    App::log()->delAllLogs();
+                } else {
+                    App::log()->delLogs($current->entries);
+                }
                 Notices::addSuccessNotice(
                     $current->all_logs ?
                     __('All logs have been successfully deleted') :
@@ -59,7 +58,7 @@ class Manage extends Process
                 );
                 My::redirect();
             } catch (Exception $e) {
-                dcCore::app()->error->add($e->getMessage());
+                App::error()->add($e->getMessage());
             }
         }
 
@@ -128,11 +127,7 @@ class Manage extends Process
                                                 ->class('delete')
                                                 ->value(__('Delete all logs')),
                                         ]),
-                                    (new Text(
-                                        '',
-                                        dcCore::app()->admin->url->getHiddenFormFields('admin.plugin.' . My::id(), $current->filter->values()) .
-                                        dcCore::app()->formNonce()
-                                    )),
+                                    ... My::hiddenFields($current->filter->values()),
                                 ]),
                         ])->render(),
                     $current->filter->show()

src/ManageVars.php

@@ -1,20 +1,10 @@
 <?php
-/**
- * @brief dcLog, a plugin for Dotclear 2
- *
- * @package Dotclear
- * @subpackage Plugin
- *
- * @author Tomtom and Contributors
- *
- * @copyright Jean-Christian Denis
- * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
- */
+
 declare(strict_types=1);
 
 namespace Dotclear\Plugin\dcLog;
 
-use dcCore;
+use Dotclear\App;
 use Dotclear\Core\Backend\Filter\{
     Filters,
     FiltersLibrary
@@ -23,29 +13,62 @@ use Dotclear\Database\MetaRecord;
 use Exception;
 
 /**
- * Backend logs manage page vars container.
+ * @brief       dcLog properties helper.
+ * @ingroup     dcLog
+ *
+ * @author      Tomtom (author)
+ * @author      Jean-Christian Denis (latest)
+ * @copyright   GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
  */
 class ManageVars
 {
-    /** @var    ManageVars  $container  self instance */
+    /**
+     * ManageVars instance.
+     *
+     * @var     ManageVars  $container
+     */
     private static $container;
 
-    /** @var    Filters     $filter     The filter instance */
+    /**
+     * The filter instance.
+     *
+     * @var     Filters     $filter
+     */
     public readonly Filters $filter;
 
-    /** @var    null|MetaRecord     $logs   The current records */
+    /**
+     * The current records.
+     *
+     * @var     null|MetaRecord     $logs
+     */
     public readonly ?MetaRecord $logs;
 
-    /** @var    null|BackendList    $list   The records list form instance */
+    /**
+     * The records list form instance.
+     *
+     * @var     null|BackendList    $list
+     */
     public readonly ?BackendList $list;
 
-    /** @var    array<int,string>   $entries    The post form selected entries */
+    /**
+     * The post form selected entries.
+     *
+     * @var     array<int,string>   $entries
+     */
     public readonly array $entries;
 
-    /** @var    bool    $selected_logs  The post form action */
+    /**
+     * The post form action.
+     *
+     * @var     bool    $selected_logs
+     */
     public readonly bool $selected_logs;
 
-    /** @var    bool    $all_logs  The post form action */
+    /**
+     * The post form action.
+     *
+     * @var     bool    $all_logs
+     */
     public readonly bool $all_logs;
 
     /**
@@ -66,12 +89,12 @@ class ManageVars
         $params = $this->filter->params();
 
         try {
-            $this->logs = dcCore::app()->log->getLogs($params);
-            $count      = dcCore::app()->log->getLogs($params, true)->f(0);
+            $this->logs = App::log()->getLogs($params);
+            $count      = App::log()->getLogs($params, true)->f(0);
             $count      = is_numeric($count) ? (int) $count : 0;
             $this->list = new BackendList($this->logs, $count);
         } catch (Exception $e) {
-            dcCore::app()->error->add($e->getMessage());
+            App::error()->add($e->getMessage());
         }
     }
 

src/My.php

@@ -1,29 +1,35 @@
 <?php
-/**
- * @brief dcLog, a plugin for Dotclear 2
- *
- * @package Dotclear
- * @subpackage Plugin
- *
- * @author Tomtom and Contributors
- *
- * @copyright Jean-Christian Denis
- * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
- */
+
 declare(strict_types=1);
 
 namespace Dotclear\Plugin\dcLog;
 
-use dcCore;
+use Dotclear\App;
 use Dotclear\Module\MyPlugin;
 
+/**
+ * @brief       dcLog My helper.
+ * @ingroup     dcLog
+ *
+ * @author      Tomtom (author)
+ * @author      Jean-Christian Denis (latest)
+ * @copyright   GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
+ */
 class My extends MyPlugin
 {
-    /** @var    string  Admin list ID */
+    /**
+     * Admin list ID.
+     *
+     * @var     string  BACKEND_LIST_ID
+     */
     public const BACKEND_LIST_ID = 'dcloglist';
 
     public static function checkCustomContext(int $context): ?bool
     {
-        return dcCore::app()->auth->isSuperAdmin();
+        return match ($context) {
+            // Limit to super admin
+            self::MODULE => App::auth()->isSuperAdmin(),
+            default      => null,
+        };
     }
 }