From b360dc199f1b0c58fa158e354a98819c44d07235 Mon Sep 17 00:00:00 2001 From: Jean-Christian Denis Date: Thu, 19 Oct 2023 21:53:53 +0200 Subject: [PATCH] cosmetic code review --- CHANGELOG.md | 6 ++++++ README.md | 14 +++++++------- _define.php | 3 +-- dcstore.xml | 4 ++-- locales/fr/resources.php | 21 ++++++--------------- src/Backend.php | 1 - src/Config.php | 1 - src/Core.php | 1 - src/Install.php | 1 - src/Manage.php | 1 - src/My.php | 1 - src/Settings.php | 1 - src/Uninstall.php | 1 - src/Utils.php | 1 - src/Zip.php | 1 - 15 files changed, 22 insertions(+), 36 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 06d579e..355d7e4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +pacKman 2023.10.19 +=========================================================== +* Require Dotclear 2.28 +* Require PHP 8.1+ +* cosmetic code review + pacKman 2023.10.13 =========================================================== * Require Dotclear 2.28 diff --git a/README.md b/README.md index edaa2e2..cf6d585 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ # README -[![Release](https://img.shields.io/badge/release-2023.10.13-a2cbe9.svg)](https://git.dotclear.watch/JcDenis/pacKman/releases) -![Date](https://img.shields.io/badge/date-2023.10.13-c44d58.svg) +[![Release](https://img.shields.io/badge/release-2023.10.19-a2cbe9.svg)](https://git.dotclear.watch/JcDenis/pacKman/releases) +![Date](https://img.shields.io/badge/date-2023.10.19-c44d58.svg) [![Dotclear](https://img.shields.io/badge/dotclear-v2.28-137bbb.svg)](https://fr.dotclear.org/download) [![Dotaddict](https://img.shields.io/badge/dotaddict-official-9ac123.svg)](https://plugins.dotaddict.org/dc2/details/pacKman) [![License](https://img.shields.io/badge/license-GPL--2.0-ececec.svg)](https://git.dotclear.watch/JcDenis/pacKman/src/branch/master/LICENSE) @@ -16,9 +16,9 @@ _pacKman_ is a plugin for the open-source web publishing software called [Dotcle * Dotclear 2.28 * PHP 8.1+ -* Super administrator permissions -* A writable cache directory -* A writable directory to put packages. (can be VAR dir) +* Dotclear super administrator permissions +* System writable cache directory +* System writable directory to put packages. (can be VAR dir) ## USAGE @@ -37,11 +37,11 @@ Once it's done you can manage your packages from menu * [Packages & details](https://git.dotclear.watch/JcDenis/pacKman/releases) (or on [Dotaddict](https://plugins.dotaddict.org/dc2/details/pacKman)) * [Sources & contributions](https://git.dotclear.watch/JcDenis/pacKman) (or on [GitHub](https://github.com/JcDenis/pacKman)) * [Issues & security](https://git.dotclear.watch/JcDenis/pacKman/issues) (or on [GitHub](https://github.com/JcDenis/pacKman/issues)) -* [Discuss and help](https://forum.dotclear.org/viewtopic.php?id=40066) +* [Discuss & help](https://forum.dotclear.org/viewtopic.php?id=40066) ## CONTRIBUTORS -* Jean-Christian Denis +* Jean-Christian Denis (author) * Philippe aka Dissitou * franck-paul diff --git a/_define.php b/_define.php index 83229ab..24181b4 100644 --- a/_define.php +++ b/_define.php @@ -9,7 +9,6 @@ * Manage your Dotclear packages. * * @author Jean-Christian Denis - * @copyright Jean-Christian Denis * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html */ declare(strict_types=1); @@ -18,7 +17,7 @@ $this->registerModule( 'Packages repository', 'Manage your Dotclear packages', 'Jean-Christian Denis', - '2023.10.13', + '2023.10.19', [ 'requires' => [['core', '2.28']], 'type' => 'plugin', diff --git a/dcstore.xml b/dcstore.xml index e67881d..35add83 100644 --- a/dcstore.xml +++ b/dcstore.xml @@ -2,10 +2,10 @@ Packages repository - 2023.10.13 + 2023.10.19 Jean-Christian Denis Manage your Dotclear packages - https://git.dotclear.watch/JcDenis/pacKman/releases/download/v2023.10.13/plugin-pacKman.zip + https://git.dotclear.watch/JcDenis/pacKman/releases/download/v2023.10.19/plugin-pacKman.zip 2.28 https://git.dotclear.watch/JcDenis/pacKman/src/branch/master/README.md https://git.dotclear.watch/JcDenis/pacKman/issues diff --git a/locales/fr/resources.php b/locales/fr/resources.php index 23bfaf9..56211b8 100644 --- a/locales/fr/resources.php +++ b/locales/fr/resources.php @@ -1,19 +1,10 @@ resources['help']['pacKman'])) { - dcCore::app()->resources['help']['pacKman'] = __DIR__ . '/help/help.html'; -} +\Dotclear\App::backend()->resources()->set('help', 'pacKman', __DIR__ . '/help/help.html'); diff --git a/src/Backend.php b/src/Backend.php index 3bebdba..526aac2 100644 --- a/src/Backend.php +++ b/src/Backend.php @@ -13,7 +13,6 @@ use Dotclear\Core\Backend\Favorites; * @ingroup pacKman * * @author Jean-Christian Denis - * @copyright Jean-Christian Denis * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html */ class Backend extends Process diff --git a/src/Config.php b/src/Config.php index 26c1491..3df717c 100644 --- a/src/Config.php +++ b/src/Config.php @@ -25,7 +25,6 @@ use Exception; * @ingroup pacKman * * @author Jean-Christian Denis - * @copyright Jean-Christian Denis * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html */ class Config extends Process diff --git a/src/Core.php b/src/Core.php index 8186ea0..ed3320e 100644 --- a/src/Core.php +++ b/src/Core.php @@ -16,7 +16,6 @@ use Exception; * @ingroup pacKman * * @author Jean-Christian Denis - * @copyright Jean-Christian Denis * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html */ class Core diff --git a/src/Install.php b/src/Install.php index 8109f04..1aa18bc 100644 --- a/src/Install.php +++ b/src/Install.php @@ -13,7 +13,6 @@ use Exception; * @ingroup pacKman * * @author Jean-Christian Denis - * @copyright Jean-Christian Denis * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html */ class Install extends Process diff --git a/src/Manage.php b/src/Manage.php index 69fbe8d..fcf2a13 100644 --- a/src/Manage.php +++ b/src/Manage.php @@ -23,7 +23,6 @@ use Exception; * @ingroup pacKman * * @author Jean-Christian Denis - * @copyright Jean-Christian Denis * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html */ class Manage extends Process diff --git a/src/My.php b/src/My.php index 8d918db..ff24bb9 100644 --- a/src/My.php +++ b/src/My.php @@ -12,7 +12,6 @@ use Dotclear\Module\MyPlugin; * @ingroup pacKman * * @author Jean-Christian Denis - * @copyright Jean-Christian Denis * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html */ class My extends MyPlugin diff --git a/src/Settings.php b/src/Settings.php index 6facf67..46cfe96 100644 --- a/src/Settings.php +++ b/src/Settings.php @@ -9,7 +9,6 @@ namespace Dotclear\Plugin\pacKman; * @ingroup pacKman * * @author Jean-Christian Denis - * @copyright Jean-Christian Denis * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html */ class Settings diff --git a/src/Uninstall.php b/src/Uninstall.php index 2112a91..29f2aa8 100644 --- a/src/Uninstall.php +++ b/src/Uninstall.php @@ -12,7 +12,6 @@ use Dotclear\Plugin\Uninstaller\Uninstaller; * @ingroup pacKman * * @author Jean-Christian Denis - * @copyright Jean-Christian Denis * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html */ class Uninstall extends Process diff --git a/src/Utils.php b/src/Utils.php index cce449d..a83abdd 100644 --- a/src/Utils.php +++ b/src/Utils.php @@ -29,7 +29,6 @@ use Exception; * @ingroup pacKman * * @author Jean-Christian Denis - * @copyright Jean-Christian Denis * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html */ class Utils diff --git a/src/Zip.php b/src/Zip.php index c983e7d..b2bb4f2 100644 --- a/src/Zip.php +++ b/src/Zip.php @@ -12,7 +12,6 @@ namespace Dotclear\Plugin\pacKman; * to tweak writeFile method. * * @author Jean-Christian Denis - * @copyright Jean-Christian Denis * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html */ class Zip extends \Dotclear\Helper\File\Zip\Zip