cosmetic code review

This commit is contained in:
Jean-Christian Paul Denis 2023-10-19 21:53:53 +02:00
parent 53ef9fd071
commit b360dc199f
Signed by: JcDenis
GPG Key ID: 1B5B8C5B90B6C951
15 changed files with 22 additions and 36 deletions

View File

@ -1,3 +1,9 @@
pacKman 2023.10.19
===========================================================
* Require Dotclear 2.28
* Require PHP 8.1+
* cosmetic code review
pacKman 2023.10.13 pacKman 2023.10.13
=========================================================== ===========================================================
* Require Dotclear 2.28 * Require Dotclear 2.28

View File

@ -1,7 +1,7 @@
# README # README
[![Release](https://img.shields.io/badge/release-2023.10.13-a2cbe9.svg)](https://git.dotclear.watch/JcDenis/pacKman/releases) [![Release](https://img.shields.io/badge/release-2023.10.19-a2cbe9.svg)](https://git.dotclear.watch/JcDenis/pacKman/releases)
![Date](https://img.shields.io/badge/date-2023.10.13-c44d58.svg) ![Date](https://img.shields.io/badge/date-2023.10.19-c44d58.svg)
[![Dotclear](https://img.shields.io/badge/dotclear-v2.28-137bbb.svg)](https://fr.dotclear.org/download) [![Dotclear](https://img.shields.io/badge/dotclear-v2.28-137bbb.svg)](https://fr.dotclear.org/download)
[![Dotaddict](https://img.shields.io/badge/dotaddict-official-9ac123.svg)](https://plugins.dotaddict.org/dc2/details/pacKman) [![Dotaddict](https://img.shields.io/badge/dotaddict-official-9ac123.svg)](https://plugins.dotaddict.org/dc2/details/pacKman)
[![License](https://img.shields.io/badge/license-GPL--2.0-ececec.svg)](https://git.dotclear.watch/JcDenis/pacKman/src/branch/master/LICENSE) [![License](https://img.shields.io/badge/license-GPL--2.0-ececec.svg)](https://git.dotclear.watch/JcDenis/pacKman/src/branch/master/LICENSE)
@ -16,9 +16,9 @@ _pacKman_ is a plugin for the open-source web publishing software called [Dotcle
* Dotclear 2.28 * Dotclear 2.28
* PHP 8.1+ * PHP 8.1+
* Super administrator permissions * Dotclear super administrator permissions
* A writable cache directory * System writable cache directory
* A writable directory to put packages. (can be VAR dir) * System writable directory to put packages. (can be VAR dir)
## USAGE ## USAGE
@ -37,11 +37,11 @@ Once it's done you can manage your packages from menu
* [Packages & details](https://git.dotclear.watch/JcDenis/pacKman/releases) (or on [Dotaddict](https://plugins.dotaddict.org/dc2/details/pacKman)) * [Packages & details](https://git.dotclear.watch/JcDenis/pacKman/releases) (or on [Dotaddict](https://plugins.dotaddict.org/dc2/details/pacKman))
* [Sources & contributions](https://git.dotclear.watch/JcDenis/pacKman) (or on [GitHub](https://github.com/JcDenis/pacKman)) * [Sources & contributions](https://git.dotclear.watch/JcDenis/pacKman) (or on [GitHub](https://github.com/JcDenis/pacKman))
* [Issues & security](https://git.dotclear.watch/JcDenis/pacKman/issues) (or on [GitHub](https://github.com/JcDenis/pacKman/issues)) * [Issues & security](https://git.dotclear.watch/JcDenis/pacKman/issues) (or on [GitHub](https://github.com/JcDenis/pacKman/issues))
* [Discuss and help](https://forum.dotclear.org/viewtopic.php?id=40066) * [Discuss & help](https://forum.dotclear.org/viewtopic.php?id=40066)
## CONTRIBUTORS ## CONTRIBUTORS
* Jean-Christian Denis * Jean-Christian Denis (author)
* Philippe aka Dissitou * Philippe aka Dissitou
* franck-paul * franck-paul

View File

@ -9,7 +9,6 @@
* Manage your Dotclear packages. * Manage your Dotclear packages.
* *
* @author Jean-Christian Denis * @author Jean-Christian Denis
* @copyright Jean-Christian Denis
* @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
*/ */
declare(strict_types=1); declare(strict_types=1);
@ -18,7 +17,7 @@ $this->registerModule(
'Packages repository', 'Packages repository',
'Manage your Dotclear packages', 'Manage your Dotclear packages',
'Jean-Christian Denis', 'Jean-Christian Denis',
'2023.10.13', '2023.10.19',
[ [
'requires' => [['core', '2.28']], 'requires' => [['core', '2.28']],
'type' => 'plugin', 'type' => 'plugin',

View File

@ -2,10 +2,10 @@
<modules xmlns:da="http://dotaddict.org/da/"> <modules xmlns:da="http://dotaddict.org/da/">
<module id="pacKman"> <module id="pacKman">
<name>Packages repository</name> <name>Packages repository</name>
<version>2023.10.13</version> <version>2023.10.19</version>
<author>Jean-Christian Denis</author> <author>Jean-Christian Denis</author>
<desc>Manage your Dotclear packages</desc> <desc>Manage your Dotclear packages</desc>
<file>https://git.dotclear.watch/JcDenis/pacKman/releases/download/v2023.10.13/plugin-pacKman.zip</file> <file>https://git.dotclear.watch/JcDenis/pacKman/releases/download/v2023.10.19/plugin-pacKman.zip</file>
<da:dcmin>2.28</da:dcmin> <da:dcmin>2.28</da:dcmin>
<da:details>https://git.dotclear.watch/JcDenis/pacKman/src/branch/master/README.md</da:details> <da:details>https://git.dotclear.watch/JcDenis/pacKman/src/branch/master/README.md</da:details>
<da:support>https://git.dotclear.watch/JcDenis/pacKman/issues</da:support> <da:support>https://git.dotclear.watch/JcDenis/pacKman/issues</da:support>

View File

@ -1,19 +1,10 @@
<?php <?php
/** /**
* @brief pacKman, a plugin for Dotclear 2 * @file
* * @brief The plugin pacKman locales resources
* @package Dotclear * @ingroup pacKman
* @subpackage Plugin
* *
* @author Jean-Christian Denis * @author Jean-Christian Denis
*
* @copyright Jean-Christian Denis
* @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
*/ */
if (!defined('DC_RC_PATH')) { \Dotclear\App::backend()->resources()->set('help', 'pacKman', __DIR__ . '/help/help.html');
return null;
}
if (!isset(dcCore::app()->resources['help']['pacKman'])) {
dcCore::app()->resources['help']['pacKman'] = __DIR__ . '/help/help.html';
}

View File

@ -13,7 +13,6 @@ use Dotclear\Core\Backend\Favorites;
* @ingroup pacKman * @ingroup pacKman
* *
* @author Jean-Christian Denis * @author Jean-Christian Denis
* @copyright Jean-Christian Denis
* @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
*/ */
class Backend extends Process class Backend extends Process

View File

@ -25,7 +25,6 @@ use Exception;
* @ingroup pacKman * @ingroup pacKman
* *
* @author Jean-Christian Denis * @author Jean-Christian Denis
* @copyright Jean-Christian Denis
* @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
*/ */
class Config extends Process class Config extends Process

View File

@ -16,7 +16,6 @@ use Exception;
* @ingroup pacKman * @ingroup pacKman
* *
* @author Jean-Christian Denis * @author Jean-Christian Denis
* @copyright Jean-Christian Denis
* @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
*/ */
class Core class Core

View File

@ -13,7 +13,6 @@ use Exception;
* @ingroup pacKman * @ingroup pacKman
* *
* @author Jean-Christian Denis * @author Jean-Christian Denis
* @copyright Jean-Christian Denis
* @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
*/ */
class Install extends Process class Install extends Process

View File

@ -23,7 +23,6 @@ use Exception;
* @ingroup pacKman * @ingroup pacKman
* *
* @author Jean-Christian Denis * @author Jean-Christian Denis
* @copyright Jean-Christian Denis
* @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
*/ */
class Manage extends Process class Manage extends Process

View File

@ -12,7 +12,6 @@ use Dotclear\Module\MyPlugin;
* @ingroup pacKman * @ingroup pacKman
* *
* @author Jean-Christian Denis * @author Jean-Christian Denis
* @copyright Jean-Christian Denis
* @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
*/ */
class My extends MyPlugin class My extends MyPlugin

View File

@ -9,7 +9,6 @@ namespace Dotclear\Plugin\pacKman;
* @ingroup pacKman * @ingroup pacKman
* *
* @author Jean-Christian Denis * @author Jean-Christian Denis
* @copyright Jean-Christian Denis
* @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
*/ */
class Settings class Settings

View File

@ -12,7 +12,6 @@ use Dotclear\Plugin\Uninstaller\Uninstaller;
* @ingroup pacKman * @ingroup pacKman
* *
* @author Jean-Christian Denis * @author Jean-Christian Denis
* @copyright Jean-Christian Denis
* @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
*/ */
class Uninstall extends Process class Uninstall extends Process

View File

@ -29,7 +29,6 @@ use Exception;
* @ingroup pacKman * @ingroup pacKman
* *
* @author Jean-Christian Denis * @author Jean-Christian Denis
* @copyright Jean-Christian Denis
* @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
*/ */
class Utils class Utils

View File

@ -12,7 +12,6 @@ namespace Dotclear\Plugin\pacKman;
* to tweak writeFile method. * to tweak writeFile method.
* *
* @author Jean-Christian Denis * @author Jean-Christian Denis
* @copyright Jean-Christian Denis
* @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html * @copyright GPL-2.0 https://www.gnu.org/licenses/gpl-2.0.html
*/ */
class Zip extends \Dotclear\Helper\File\Zip\Zip class Zip extends \Dotclear\Helper\File\Zip\Zip