use svg icon and fix admin url

_admin.php

@@ -45,7 +45,7 @@ if (dcCore::app()->blog->settings->periodical->periodical_active) {
     dcCore::app()->menu[dcAdmin::MENU_PLUGINS]->addItem(
         __('Periodical'),
         dcCore::app()->adminurl->get('admin.plugin.periodical'),
-        dcPage::getPF('periodical/icon.png'),
+        dcPage::getPF('periodical/icon.svg'),
         preg_match('/' . preg_quote(dcCore::app()->adminurl->get('admin.plugin.periodical')) . '(&.*)?$/', $_SERVER['REQUEST_URI']),
         dcCore::app()->auth->check(dcCore::app()->auth->makePermissions([
             dcAuth::PERMISSION_USAGE,
@@ -55,7 +55,7 @@ if (dcCore::app()->blog->settings->periodical->periodical_active) {
 
     dcCore::app()->addBehavior(
         'adminDashboardFavoritesV2',
-        ['adminPeriodical', 'adminDashboardFavorites']
+        ['adminPeriodical', 'adminDashboardFavoritesV2']
     );
     dcCore::app()->addBehavior(
         'adminPostHeaders',
@@ -233,13 +233,13 @@ class adminPeriodical
      *
      * @param   dcFavorites $favs Array of favorites
      */
-    public static function adminDashboardFavorites(dcFavorites $favs)
+    public static function adminDashboardFavoritesV2(dcFavorites $favs)
     {
         $favs->register('periodical', [
             'title'       => __('Periodical'),
-            'url'         => 'plugin.php?p=periodical',
-            'small-icon'  => 'index.php?pf=periodical/icon.png',
-            'large-icon'  => 'index.php?pf=periodical/icon-big.png',
+            'url'         => dcCore::app()->adminurl->get('admin.plugin.periodical'),
+            'small-icon'  => dcPage::getPF('periodical/icon.svg'),
+            'large-icon'  => dcPage::getPF('periodical/icon.svg'),
             'permissions' => dcCore::app()->auth->check(
                 dcCore::app()->auth->makePermissions([
                     dcAuth::PERMISSION_USAGE,
@@ -247,26 +247,9 @@ class adminPeriodical
                 ]),
                 dcCore::app()->blog->id
             ),
-            'active_cb' => [
-                'adminPeriodical',
-                'adminDashboardFavoritesActive',
-            ],
         ]);
     }
 
-    /**
-     * Favorites selection.
-     *
-     * @param   string $request Requested page
-     * @param   array  $params  Requested parameters
-     */
-    public static function adminDashboardFavoritesActive($request, $params)
-    {
-        return $request == 'plugin.php'
-            && isset($params['p'])
-            && $params['p'] == 'periodical';
-    }
-
     /**
      * Add javascript for toggle
      *
@@ -274,7 +257,7 @@ class adminPeriodical
      */
     public static function adminPostHeaders()
     {
-        return dcPage::jsLoad('index.php?pf=periodical/js/toggle.js');
+        return dcPage::jsLoad(dcPage::getPF('periodical/js/toggle.js'));
     }
 
     /**

icon.svg

@@ -0,0 +1,32 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
+<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" width="64px" height="64px" viewBox="0 0 64 64" enable-background="new 0 0 64 64" xml:space="preserve">  <image id="image0" width="64" height="64" x="0" y="0"
+    href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEAAAABACAQAAAAAYLlVAAAABGdBTUEAALGPC/xhBQAAACBjSFJN
+AAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAAmJLR0QA/4ePzL8AAAAJcEhZ
+cwAADsMAAA7DAcdvqGQAAAAHdElNRQfmCxoPKTrNq9WxAAAE1ElEQVRo3u3Z324b1xHH8Q+5y3+i
+pEqWFMmWXSVGrcZRECRACxRFBDa66H3R1ylq+Fly3aJP4IBQ0F60RS9apHCb2LCDGJaVOEQskbK0
+5PaCpEmJS3JJmwGMZgAK1GJ/c75nzsw5s0v+3y0z5HreTb/xKwV/80d/dTSF73k/91s/c+ITf/Jv
+p0k3hUPBAgVlRSXhUMxxkwsVlQWKgmE+wqHy0JwlJfNyUwPkzFvWMDd8nOERyCooKSkIphq+7b2o
+hILssElkR84gKysrM3UEuj5G6MO+W9ufWCxOdJceZJyPuPdpAxTlFDtrHamrD0gDJXPyqRBip+oa
+CZOdUxYgdubEmUYX4LJl65bk8Mw99wdKpmDTDZdS5UPTNz735cDsy667bh5nag58614X4AMbrltX
+FDuQ88TZAMCWD70llwLgzD1nnmgNAGzbtYETB+553AP4tRWbluW1PPS54oVQZ+Ss2rajkALguZx/
+yl2IYkbRZe/YknHqqS1f+0MX4ENzFpRkNdXNJwQ6q2TFekqAx0oJ9RWYt2pdoGXVRjtL2gA/FsgJ
+0JR/sWvFfX8zAjmFVADkhvrId/aVvDlRD6D0okD6i62lKdISywg6LtMVYveuWEuk+SIbMi/8B7Ly
+PYDzIc8KZEXqaoqORLLyfbNKAxAIcOZIzYm6qONVH4oewPmVKllUUHff3+XdVRNaMD/i3Lg4fKhs
+wYmau0Kn7qsrWFQazK5BpwWrrnrq2D88EXji0JwNqwO1MRygZN2mhq/9xReavnJs2VWrgzkUJoiv
+2fGdLzz0SEYka9Pb3rQw8uToX8IF173j2CP/dV8skvemHdeULk4iCWDL+45FHmmIFazZ8YGfTACw
+6IZnGjj0XEbZFe9531YagLw1N8V+5IGa2LxNN73ryqB4xBJcEcla9ZUjGUu27LhpbfA06a9Wne9N
+Dd868FhNy4J1Gy4pC1NGgJbIsaceO/BM1pIN65aVLlRSJgmgfZg2nfjOsVjJgrJwwq4gFosce6Yh
+o2yx05Zd3OITAdrWFIkQCCfYAc5DNEWaCIWJ5+hIgN7V6fqhND7GAMzeMv1VEGtpDmmlXu2gGUGv
+T+wBRJ46dPw9AJStudRtbboAsbr/+LMvB3qhV2051/zSexbbMehF4LkHPvUvz2cMUPCuTT/t/tsD
+aKr7xoGTGQMUXVbXHARgeD//Ku3CCGk315nZ6wSwtbu1+7vdSQcYp0pqs3btqZy7UnWHB3t8fGeo
+p+lUiRHYU7ngij23/X7g6surEgEqKgPX286rD/aHeppONaTTrWLvXHgr3ZCOsKlUaZJw120VVbfs
+p7h7QlU4wsEe7tjvS67dsQgTq0Y9bFRUVFQ7gWyHd3wMJlSNftrJ+shHWqpuuT06m6dVDc+Bfbd8
+0vleTb36E6vCMc6ojM3+l1KFKZylWfmpVckAFdkB/vaqjrKpVEkAVRJSp6U60tV0qkSA5LWrjlnV
+6VSJAPsTrvnLqF6rhuQHgB8AZmO9Muy+SJ21FTovg+N+gPZbjBXbJP+49gotb9uKQLON0AY4EsrZ
+xi96T20zssCKG0JH7am2Ae5atOyytS7XDC0jEGo4VOsBfOqat121NOXrqEks1nTk0Gce9gA+E3nD
+G+Kpf6KbDOFUzUN3Zz7Sa2H/A71CaGpIF/8oAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTExLTI2
+VDE0OjQxOjU4KzAxOjAw1vpZdQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0xMS0yNlQxNDo0MTo1
+OCswMTowMKen4ckAAAAadEVYdFNvZnR3YXJlAFBhaW50Lk5FVCB2My41LjExR/NCNwAAAABJRU5E
+rkJggg==" />
+</svg>